Check whether data model provider is set in report callbacks #36881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36881: Size comparison from 37fa873 to 7ca202a Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| InteractionModelEngine::GetInstance()->GetDataModelProvider()->Temporary_ReportAttributeChanged( | ||
| AttributePathParams(endpoint, clusterId, attributeId)); | ||
| auto * engine = InteractionModelEngine::GetInstance(); | ||
| VerifyOrReturn(engine); |
There was a problem hiding this comment.
Why is anyone calling this before data model has been initialized? That indicates a serious bug, and papering over it like this will just lead to wrong behavior as far as I can tell....
There was a problem hiding this comment.
In my test, InitChipStack() is called before Server instance is initialized. And before server instance is initialized, the connectivityMgr(this is initialized with the chip stack) might receive a Wi-Fi connect event, which will lead to that the Wi-Fi driver tries to call MatterReportingAttributeChangeCallback() to report the network status change. If the server instance doesn't set the data model provider for IM engine at that, there will be crash.
There was a problem hiding this comment.
I see, so this is a case where the attribute value is not owned by the data model at all, so it's ok if it's changing before the data model is set up?
There was a problem hiding this comment.
The network status is read from the network driver so that it might be changed before data model is set up. I raised another PR #36939 which does the check before at where the network status is reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the check to fix crash when calling the reporting callbacks at the time when the server instance is not initialized.